Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hardware wallet support via frame signer #17

Merged
merged 14 commits into from
Nov 10, 2021
Merged

feat: hardware wallet support via frame signer #17

merged 14 commits into from
Nov 10, 2021

Conversation

banteg
Copy link
Owner

@banteg banteg commented Nov 3, 2021

Add ability to sign Safe transactions using Ledger, Trezor and Lattice1 via Frame.

Tested on Ethereum Mainnet with Ledger Nano X.

New API:

  • get_signer()
  • sign_with_frame(safe_tx)
  • post_signature(safe_tx, signature_
  • pending_transactions
  • confirmations_to_signatures(confirmations)
  • execute_transaction

Some specific combinations I want tested:

  • safe on any network but eth mainnet which has a ledger as owner (ledger doesn't support eip155 and i want to see if i implemented the fix for it correctly)
  • safe on any network with any trezor model as owner
  • safe on any network with lattice1 as owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant